Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/12762#discussion_r61501824
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala ---
@@ -58,6 +58,30 @@ object MLTestingUtils extends SparkFunSuite {
"Column label must be of type NumericType but was actually of type
StringType"))
}
+ def checkNumericTypesALS[M <: Model[M], T <: Estimator[M]](
+ estimator: T,
+ sqlContext: SQLContext,
+ column: String,
+ baseType: NumericType)
+ (check: (M, M) => Unit)
+ (check2: (M, M, DataFrame) => Unit): Unit = {
+ val dfs = genRatingsDFWithNumericCols(sqlContext, column)
--- End diff --
the indent seems off for the params
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
