Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/12640#discussion_r61509114
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java
---
@@ -336,4 +336,78 @@ public UnsafeArrayData copy() {
arrayCopy.pointTo(arrayDataCopy, Platform.BYTE_ARRAY_OFFSET,
sizeInBytes);
return arrayCopy;
}
+
+ /**
+ * A faster version of `toIntArray`, which use memory copy instead of
iterating all elements.
+ * Note that, this method is dangerous if this array contains null
elements. We don't write
+ * null elements into the data region and memory copy will crash as the
data size doesn't match.
+ */
+ public int[] toIntArrayUnchecked() {
+ int[] result = new int[numElements];
+ Platform.copyMemory(baseObject, baseOffset + 4 + 4L * numElements,
+ result, Platform.INT_ARRAY_OFFSET, 4L * numElements);
+ return result;
+ }
+
+ /**
+ * A faster version of `toDoubleArray`, which use memory copy instead of
iterating all elements.
+ * Note that, this method is dangerous if this array contains null
elements. We don't write
+ * null elements into the data region and memory copy will crash as the
data size doesn't match.
+ */
+ public double[] toDoubleArrayUnchecked() {
+ double[] result = new double[numElements];
+ Platform.copyMemory(baseObject, baseOffset + 4 + 4L * numElements,
+ result, Platform.DOUBLE_ARRAY_OFFSET, 8L * numElements);
+ return result;
+ }
+
+ public static UnsafeArrayData fromPrimitiveArray(int[] arr) {
+ int offsetRegionSize = 4 * arr.length;
--- End diff --
Please check that `4 * arr.length` won't overflow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
