Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12768#discussion_r61523655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
---
@@ -42,13 +42,14 @@ object TypeUtils {
}
def checkForSameTypeInputExpr(types: Seq[DataType], caller: String):
TypeCheckResult = {
- if (types.distinct.size > 1) {
- TypeCheckResult.TypeCheckFailure(
- s"input to $caller should all be the same type, but it's " +
- types.map(_.simpleString).mkString("[", ", ", "]"))
- } else {
- TypeCheckResult.TypeCheckSuccess
- }
+ types.foreach ( t =>
--- End diff --
(Maybe a curly brace for multiple lines of transformation function.)
```scala
types.foreach { t =>
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
