Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/1722#discussion_r15725641
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -389,27 +404,51 @@ class ExternalAppendOnlyMap[K, V, C](
* An iterator that returns (K, C) pairs in sorted order from an on-disk
map
*/
private class DiskMapIterator(file: File, blockId: BlockId, batchSizes:
ArrayBuffer[Long])
- extends Iterator[(K, C)] {
- private val fileStream = new FileInputStream(file)
- private val bufferedStream = new BufferedInputStream(fileStream,
fileBufferSize)
+ extends Iterator[(K, C)]
+ {
--- End diff --
Those asserts caught the bugs :-) Bug yeah, some of them might have been
expensive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
