Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/12719#issuecomment-215620606
  
    the scope of `NullPropagation` is one operator, but we need a 
`FoldablePropagation` whose scope is the whole plan tree. Think about `Sort(a, 
Filter(true, Project(1 AS a)))`, we should be able to propagate the foldable 
information up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to