Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r61543239
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -1317,23 +1317,22 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
private[spark] def cleanShuffleDependencies[T](sc: SparkContext, deps:
Seq[Dependency[_]],
blocking: Boolean = false): Unit = {
// If there is no reference tracking we skip clean up.
- if (sc.cleaner.isEmpty) {
- return
- }
- val cleaner = sc.cleaner.get
- /**
- * Clean the shuffles & all of its parents.
- */
- def cleanEagerly(dep: Dependency[_]): Unit = {
- if (dep.isInstanceOf[ShuffleDependency[_, _, _]]) {
- val shuffleId = dep.asInstanceOf[ShuffleDependency[_, _,
_]].shuffleId
- cleaner.doCleanupShuffle(shuffleId, blocking)
- }
- val rdd = dep.rdd
- if (rdd.dependencies != null) {
- rdd.dependencies.foreach(cleanEagerly)
+ sc.cleaner.foreach{cleaner =>
--- End diff --
minor nit - spaces: `foreach { cleaner =>`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
