Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/12604#issuecomment-215825235
  
    @yinxusen  Thanks very much for working on this patch.  I’ve spent quite 
a bit of time trying to figure out how to simplify it, but given the very 
little time left before the code freeze, I think it will be best if we exclude 
persistence for model tuning in Python for this release.  To keep the current 
approach, we would need to clearly document its limitations, and the current 
approach is too ad-hoc for me to be confident in writing that documentation.  I 
think we can design a cleaner approach for the next release, including some 
general simplifications to the Python wrapper API.
    
    I’ll work on reverting the current save/load for python tuning and CC you 
on the PRs.
    
    Could you please close this issue?  Please keep the branch since the 
integration test will be useful in the future.  Also, could you please send a 
small patch with the Scala fixes which are in your PR?
    
    Thanks a lot!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to