Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1309#discussion_r15726410
--- Diff: core/src/main/scala/org/apache/spark/Accumulators.scala ---
@@ -36,15 +36,24 @@ import org.apache.spark.serializer.JavaSerializer
*
* @param initialValue initial value of accumulator
* @param param helper object defining how to add elements of type `R` and
`T`
+ * @param _name human-readable name for use in Spark's web UI
+ * @param display whether to show accumulator values Spark's web UI
* @tparam R the full accumulated data (result type)
* @tparam T partial data that can be added in
*/
class Accumulable[R, T] (
@transient initialValue: R,
- param: AccumulableParam[R, T])
+ param: AccumulableParam[R, T],
+ _name: Option[String],
+ val display: Boolean)
--- End diff --
Why do we initialize display to true by default everywhere? It might be
better to make it false and show only accumulators that people give names to.
Many user data types, such as vectors, will not have very nice printed forms,
and might clutter the web UI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
