Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12812#discussion_r61673327
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala 
---
    @@ -148,7 +165,10 @@ class DDLSuite extends QueryTest with SharedSQLContext 
with BeforeAndAfterEach {
             try {
               val dbNameWithoutBackTicks = cleanIdentifier(dbName)
               val location =
    -            System.getProperty("java.io.tmpdir") + File.separator + 
s"$dbNameWithoutBackTicks.db"
    +            catalog.makeQualifiedPath(
    --- End diff --
    
    it'd be great to make the testing of qualified path more explicit, e.g. by 
having a test case dedicated to it.
    
    The remaining test cases can just check the path is part of the intended 
qualified path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to