GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/12816
[SPARK-14931][ML][PYTHON] Mismatched default values between pipelines in
Spark and PySpark - update
## What changes were proposed in this pull request?
This PR is an update for [https://github.com/apache/spark/pull/12738] which:
* Adds a generic unit test for JavaParams wrappers in pyspark.ml for
checking default Param values vs. the defaults in the Scala side
* Various fixes for bugs found
* This includes changing classes taking weightCol to treat unset and
empty String Param values the same way.
## How was this patch tested?
Generic unit test. Manually tested that unit test by changing defaults and
verifying that broke the test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark yinxusen-SPARK-14931
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12816
----
commit e8f0d65372de63cd7792824bcddad05a2e162d0d
Author: yinxusen <[email protected]>
Date: 2016-04-27T17:46:39Z
fix bug
commit 42239c5dafa096b5fbf008999ba34003dd598002
Author: yinxusen <[email protected]>
Date: 2016-04-29T03:27:14Z
add auto-test for default values
commit 1e35c1f649dc23a475521b024e4b2828da8f9932
Author: Joseph K. Bradley <[email protected]>
Date: 2016-04-30T20:06:59Z
Updated fixes for default values
commit a356f18839905a99702b59d4feeaed9bddb34c8f
Author: Joseph K. Bradley <[email protected]>
Date: 2016-04-30T22:00:15Z
Doc for default Param test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
