Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1715#discussion_r15727020
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -311,6 +311,15 @@ private[spark] class SparkSubmitArguments(args:
Seq[String]) {
verbose = true
parse(tail)
+ case "--" :: tail =>
+ if (inSparkOpts) {
+ SparkSubmit.printErrorAndExit(
+ "Application option separator \"--\" must be after the primary
resource " +
+ "(i.e., application jar file or Python file).")
+ } else {
+ childArgs ++= tail.filter(_.nonEmpty)
--- End diff --
This behavior is actually inherited from [the current master
code](https://github.com/apache/spark/blob/e8e0fd691a06a2887fdcffb2217b96805ace0cb0/core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala#L347-L349).
But I agree with you, since `--` is a newly introduced argument passing mode,
we should allow empty argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
