Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12817#issuecomment-216089939
The scala changes lgtm.
One thing I just realized -- for Python, I think we should turn those into
named arguments, rather than just options. Can you do that in a separate pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
