Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12837#discussion_r61708740
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -102,19 +102,20 @@ class TaskMetrics private[spark] () extends
Serializable {
// Setters and increment-ers
private[spark] def setExecutorDeserializeTime(v: Long): Unit =
--- End diff --
Since these now all call add (and don't reset), should we consider perhaps
renaming them (or calling reset before add)? They are internal so no harm in
renaming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
