Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12829#discussion_r61731132
--- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java
---
@@ -389,12 +389,6 @@ public long cleanUpAllAllocatedMemory() {
consumers.clear();
}
- for (MemoryBlock page : pageTable) {
--- End diff --
It's not clear this code should be removed, though I agree right now it
appears to be dead code because of line 382. CC @JoshRosen since I think you
added this block? should line 382 just be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
