Github user viirya commented on the pull request:

    https://github.com/apache/spark/pull/12729#issuecomment-216245697
  
    
    BTW, benchmark with two skewness.
    
    codes:
    
        test("skewness and skewness") {
          val N = 50L << 20
          runBenchmark("skewness and skewness", N) {
            sqlContext.range(N).agg(skewness("id"), skewness("id")).collect()
          }
        }
    
    old:
    
        Java HotSpot(TM) 64-Bit Server VM 1.8.0_25-b17 on Linux 
3.13.0-57-generic
        Westmere E56xx/L56xx/X56xx (Nehalem-C)
        skewness and skewness:              Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
        
-------------------------------------------------------------------------------------------
        skewness and skewness codegen=false    11623 / 11908          4.5       
  221.7       1.0X
        skewness and skewness codegen=true       2405 / 2481         21.8       
   45.9       4.8X
    
    new:
    
        Java HotSpot(TM) 64-Bit Server VM 1.8.0_25-b17 on Linux 
3.13.0-57-generic
        Westmere E56xx/L56xx/X56xx (Nehalem-C)
        skewness and skewness:              Best/Avg Time(ms)    Rate(M/s)   
Per Row(ns)   Relative
        
-------------------------------------------------------------------------------------------
        skewness and skewness codegen=false    11570 / 12089          4.5       
  220.7       1.0X
        skewness and skewness codegen=true       2008 / 2100         26.1       
   38.3       5.8X
    
    
    
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to