Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11919#discussion_r61764867
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -520,6 +488,81 @@ class ALSSuite
}
}
+class ALSCleanerSuite extends SparkFunSuite {
+ test("Clean shuffles") {
--- End diff --
This is not about the style. It is not clear about what it does from the
name, especially when the two tests are named "Clean shuffles" and "ALS shuffle
cleanup" and both are under "ALSCleanerSuite". You don't need to use the name
suggested by me. Just make sure the name concisely describe the test itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
