Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12846#discussion_r61804511
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -726,6 +726,14 @@ private[sql] class SQLConf extends Serializable with 
CatalystConf with Logging {
       }
     
       /**
    +   * Return the value of an optional Spark SQL configuration property for 
the given key. If the key
    +   * is not set yet, returns None.
    +   */
    +  def getOptionalConf[T](entry: OptionalConfigEntry[T]): Option[T] = {
    --- End diff --
    
    Ah, that's the configuration that caused all this... so I'm wondering if 
that method shouldn't also return `Option[T]`. IIRC there's only one place 
where that method is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to