Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12837#discussion_r61834496
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -295,12 +295,12 @@ private[spark] class Executor(
// Deserialization happens in two parts: first, we deserialize a
Task object, which
// includes the Partition. Second, Task.run() deserializes the RDD
and function to be run.
- task.metrics.setExecutorDeserializeTime(
+ task.metrics.incExecutorDeserializeTime(
(taskStart - deserializeStartTime) +
task.executorDeserializeTime)
// We need to subtract Task.run()'s deserialization time to avoid
double-counting
- task.metrics.setExecutorRunTime((taskFinish - taskStart) -
task.executorDeserializeTime)
- task.metrics.setJvmGCTime(computeTotalGcTime() - startGCTime)
- task.metrics.setResultSerializationTime(afterSerialization -
beforeSerialization)
+ task.metrics.incExecutorRunTime((taskFinish - taskStart) -
task.executorDeserializeTime)
--- End diff --
So we do need the `setValue` function here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
