Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11105#discussion_r61837513
--- Diff: core/src/main/scala/org/apache/spark/AccumulatorV2.scala ---
@@ -21,33 +21,77 @@ import java.{lang => jl}
import java.io.ObjectInputStream
import java.util.concurrent.ConcurrentHashMap
import java.util.concurrent.atomic.AtomicLong
+import javax.annotation.concurrent.GuardedBy
+
+import scala.collection.mutable
import org.apache.spark.scheduler.AccumulableInfo
import org.apache.spark.util.Utils
-
+/**
+ * Metadata for the Accumulator
+ *
+ *
+ * @param countFailedValues whether to accumulate values from failed
tasks. This is set to true
+ * for system and time metrics like serialization
time or bytes spilled,
+ * and false for things with absolute values like
number of input rows.
+ * This should be used for internal metrics only.
+
+ * @param dataProperty Data property accumulators will only have values
added once for each
--- End diff --
I think `dataProperty` might possibly be clearer than `countOnRetry`, what
do @squito / @rxin think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
