Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12865#discussion_r61874253
  
    --- Diff: core/src/main/scala/org/apache/spark/util/AccumulatorV2.scala ---
    @@ -126,23 +126,9 @@ abstract class AccumulatorV2[IN, OUT] extends 
Serializable {
       def merge(other: AccumulatorV2[IN, OUT]): Unit
     
       /**
    -   * Access this accumulator's current value; only allowed on driver.
    +   * Defines the current value of this accumulator
        */
    -  final def value: OUT = {
    -    if (atDriverSide) {
    --- End diff --
    
    We should put this check in the old accumulator, to avoid breaking its 
behaviour.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to