Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12708#discussion_r61924540
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
    @@ -335,6 +358,19 @@ trait Row extends Serializable {
       def getAs[T](fieldName: String): T = getAs[T](fieldIndex(fieldName))
     
       /**
    +   * Returns the value of a given fieldName as a scala.util.Try object.
    +   */
    +  def attempt[T](fieldName: String): Try[T] = 
Try(getAs[T](fieldIndex(fieldName)))
    --- End diff --
    
    Yeah, sorry if I wasn't being clear earlier.  There certainly is still room 
for improvement here if you are still looking to contribute.  Some ideas:
     - That error message doesn't tell you which column the problem happens in.
     - Its using an old reflection based codepath instead of encoders (which 
would probably be much faster).
     - Here, it might be nice to have the option to get `nulls` instead of 
exceptions, though this would have to be optional.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to