Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/12843#discussion_r61947349
--- Diff: python/pyspark/ml/feature.py ---
@@ -1763,28 +1763,22 @@ class StopWordsRemover(JavaTransformer,
HasInputCol, HasOutputCol, JavaMLReadabl
"comparison over the stop words",
typeConverter=TypeConverters.toBoolean)
@keyword_only
- def __init__(self, inputCol=None, outputCol=None, stopWords=None,
- caseSensitive=False):
+ def __init__(self, inputCol=None, outputCol=None, stopWords=None,
caseSensitive=False):
"""
- __init__(self, inputCol=None, outputCol=None, stopWords=None,\
- caseSensitive=false)
+ __init__(self, inputCol=None, outputCol=None, stopWords=None,
caseSensitive=false)
"""
super(StopWordsRemover, self).__init__()
self._java_obj =
self._new_java_obj("org.apache.spark.ml.feature.StopWordsRemover",
self.uid)
- stopWordsObj = _jvm().org.apache.spark.ml.feature.StopWords
- defaultStopWords = list(stopWordsObj.English())
- self._setDefault(stopWords=defaultStopWords, caseSensitive=False)
+
self._setDefault(stopWords=StopWordsRemover.loadStopWords("english"),
caseSensitive=False)
kwargs = self.__init__._input_kwargs
self.setParams(**kwargs)
@keyword_only
@since("1.6.0")
- def setParams(self, inputCol=None, outputCol=None, stopWords=None,
- caseSensitive=False):
+ def setParams(self, inputCol=None, outputCol=None, stopWords=None,
caseSensitive=False):
"""
- setParams(self, inputCol="input", outputCol="output",
stopWords=None,\
- caseSensitive=false)
+ setParams(self, inputCol="input", outputCol="output",
stopWords=None, caseSensitive=false)
--- End diff --
doc: inputCol, outputCol should not have defaults
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
