Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12081#issuecomment-216752333
@andrewor14 I also think about creating directory in implementation of
create database.
Metastore APIs created the directory for us no matter whether the provided
location/directory exists or not. The following test cases verified it.
https://github.com/gatorsmile/spark/blob/mkdir/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala#L401-L411
Should we still create the database directory?
If yes, could we do it in a separate PR? This PR has a long change history.
It has been rebased 8 times.
It is hard for the future readers to follow what we did in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
