Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1643#discussion_r15731276
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala ---
@@ -107,7 +113,9 @@ private[spark] class PythonWorkerFactory(pythonExec:
String, envVars: Map[String
// Wait for it to connect to our socket
serverSocket.setSoTimeout(10000)
try {
- return serverSocket.accept()
+ val socket = serverSocket.accept()
+ simpleWorkers.put(socket, pb)
--- End diff --
As an experiment, I added the line
```scala
simpleWorkers(socket).destroy()
```
and, as expected, this results in a `java.lang.ProcessBuilder cannot be
cast to java.lang.Process` error.
The compiler should have prevented this, so I think we've found a compiler
bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
