Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12696#discussion_r62042758
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -575,8 +575,13 @@ class SparkSubmitSuite
// NOTE: This is an expensive operation in terms of time (10 seconds+).
Use sparingly.
private def runSparkSubmit(args: Seq[String]): Unit = {
val sparkHome = sys.props.getOrElse("spark.test.home",
fail("spark.test.home is not set!"))
+ val sparkSubmit = if (Utils.isWindows) {
+ Seq(new File("..\\bin\\spark-submit.cmd").getAbsolutePath) ++ args
+ } else {
+ Seq("./bin/spark-submit") ++ args
--- End diff --
OK this PR looks fine to me. My last suggested change would be to simply
this changed bit of code to something like ...
```
val sparkSubmitPath = if (Utils.isWindows) "..." else "..."
...
val process = Utils.executeCommand(
sparkSubmitPath.getAbsolutePath +: args,
...
```
I don't feel strongly about it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
