Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12882#discussion_r62079416
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -97,6 +98,7 @@ class MulticlassClassificationEvaluator @Since("1.5.0")
(@Since("1.5.0") overrid
case "recall" => true
case "weightedPrecision" => true
case "weightedRecall" => true
+ case "accuracy" => true
--- End diff --
I think one big case could be better, which leaves an incremental option of
returning false in the future. If we simple return true now and any metric in
the future returns false, we need to add back everything else returning true,
which has the potential of missing some metric and is less obvious for people
making changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
