GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/12903
Fix flaky test: o.a.s.streaming.kafka.DirectKafkaStreamSuite.offset recovery
## What changes were proposed in this pull request?
Because this test extracts data from `DStream.generatedRDDs` before
stopping, it may get data before checkpointing. Then after recovering from the
checkpoint, `recoveredOffsetRanges` may contain something not in
`offsetRangesBeforeStop`, which will fail the test. Adding `Thread.sleep(1000)`
before `ssc.stop()` will reproduce this failure.
This PR just moves the logic of `offsetRangesBeforeStop` (also renamed to
`offsetRangesAfterStop`) after `ssc.stop()` to fix the flaky test.
## How was this patch tested?
Jenkins unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-6005
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12903.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12903
----
commit 91115b87a98485eca6bd4a8e62b27ccbfc145e41
Author: Shixiong Zhu <[email protected]>
Date: 2016-05-04T18:32:39Z
Fix flaky test: o.a.s.streaming.kafka.DirectKafkaStreamSuite.offset recovery
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
