Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12899#discussion_r62112750
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1097,8 +1097,8 @@ class DAGScheduler(
                 throw new SparkException(s"attempted to access non-existent 
accumulator $id")
             }
             acc.merge(updates.asInstanceOf[AccumulatorV2[Any, Any]])
    -        // To avoid UI cruft, ignore cases where value wasn't updated
    -        if (acc.name.isDefined && !updates.isZero) {
    +        // Only display named accumulators on UI.
    +        if (acc.name.isDefined) {
    --- End diff --
    
    it's because the executor no longer sends back updates where the value is 
zero, so the second condition is always assumed to be true. Maybe we should add 
an assert or something instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to