GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/1744
[SPARK-2627] have the build enforce PEP 8 automatically
As described in
[SPARK-2627](https://issues.apache.org/jira/browse/SPARK-2627), we'd like
Python code to automatically be checked for PEP 8 compliance by Jenkins. This
pull request aims to do that.
Notes:
* We may need to install [`pep8`](https://pypi.python.org/pypi/pep8) on the
build server.
* I'm expecting tests to fail now that PEP 8 compliance is being checked as
part of the build. I'm fine with cleaning up any remaining PEP 8 violations as
part of this pull request.
* I did not understand why the RAT and scalastyle reports are saved to text
files. I did the same for the PEP 8 check, but only so that the console output
style can match those for the RAT and scalastyle checks. The PEP 8 report is
removed right after the check is complete.
* Updates to the ["Contributing to
Spark"](https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark)
guide will be submitted elsewhere, as I don't believe that text is part of the
Spark repo.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1744
----
commit 75ad55211397345e5192a19513d478b913028506
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:13:21Z
make check output style consistent
The RAT and PEP8 checks donât print a blank line after successful runs.
The scalastyle check shouldnât either.
commit 61c07b911b033b0356326397a6b7168dc94e6632
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:15:49Z
[SPARK-2627] add Python linter
This guy just runs the pep8 utility on all code in the python
directory, minus cloudpickle, which is a 3rd-party library.
commit 12440faa1a0a8b7eb41c5778ea49c360cb0de532
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:23:06Z
[SPARK-2627] add Scala linter
This guy just calls scalastyle.
commit 0541ebb5f30973aa54157256b4e43decfa9de8ba
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:23:30Z
[SPARK-2627] call Python linter from run-tests
commit 723ed39fb5067e3827a3e1f5434fb111b8e498cc
Author: Nicholas Chammas <[email protected]>
Date: 2014-08-02T23:24:00Z
always delete the report file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
