Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/12751#discussion_r62136440
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -716,7 +716,15 @@ private[spark] class TaskSetManager(
failedExecutors.getOrElseUpdate(index, new HashMap[String, Long]()).
put(info.executorId, clock.getTimeMillis())
sched.dagScheduler.taskEnded(tasks(index), reason, null, accumUpdates,
info)
- addPendingTask(index)
+
+ if (successful(index)) {
+ logWarning(
+ s"Task ${info.id} in stage ${taskSet.id} (TID $tid) will not be
re-queued " +
--- End diff --
This change mostly looks good, but can you make this log message a little
clearer? I'd move it to logInfo (since it's not something the user should be
concerned about, so doesn't seem severe enough for warning) and make it say
something like "Task ${info.id} in stage ${taskSet.id} failed, but another
instance of the task has already succeeded, so not re-queuing the task to be
re-executed."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
