Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/11956#issuecomment-217047879
@davies, thank you for your comment. Based on your previous comment, [this
commit](https://github.com/apache/spark/pull/11956/commits/d2161d13dab9871ce0e325fcc3934c2f4f5eca13)
already moved some stuff of the implementation to ```InMemoryTableScanExec```.
Now, ```WholeStageCodegenExec``` does only the following three features.
1. decide whether code for columnar storage should be generated
2. generate ```processRow()``` and ```processBatch```
3. generate runtime conditional-if statement whether ```processRow()``` or
```processBatch``` called
Do you mean these three features should be moved to
```InMemoryTableScanExec```? While I could do, my understanding is that these
features would be implemented by methods in a singleton
```InMemoryTableScanExec```. Do you have any other good ideas to implement
these features in ```InMemoryTableScanExec```?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
