Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/12887#issuecomment-217054062
Ah yes - I missed that. I think the logic is fine and matches the python
API. LGTM. One minor thing: could we add test cases for all 3 scenarios
detailed in the description ? I think we have it for the only column is
specified case right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
