Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/11157#discussion_r62158505
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -72,13 +71,13 @@ private[spark] class CoarseMesosSchedulerBackend(
private val shuffleServiceEnabled =
conf.getBoolean("spark.shuffle.service.enabled", false)
// Cores we have acquired with each Mesos task ID
- val coresByTaskId = new HashMap[String, Int]
+ val coresByTaskId = new mutable.HashMap[String, Int]
--- End diff --
Right now the code has at the imports section:
import scala.collection.mutable
import scala.collection.mutable.{Buffer, HashMap, HashSet}
and bellow:
val coresByTaskId = new HashMap[String, Int]
So the mutable is used anyway, at least this is shown to my IDE.
I just made the mutable explicit because its cleaner.
As for the mutable vs immutable problem mutable is already used and IMHO
needed eg.
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala#L483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
