Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12882#discussion_r62160186
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala 
---
    @@ -138,24 +138,30 @@ class MulticlassMetrics @Since("1.1.0") 
(predictionAndLabels: RDD[(Double, Doubl
       /**
        * Returns precision
        */
    -  @Since("1.1.0")
    +  @deprecated("Use accuracy. This metric will be removed in 2.1.0.", 
"2.0.0")
       lazy val precision: Double = tpByClass.values.sum.toDouble / labelCount
     
       /**
        * Returns recall
    -   * (equals to precision for multiclass classifier
    +   * (equals to accuracy for multiclass classifier
        * because sum of all false positives is equal to sum
        * of all false negatives)
        */
       @Since("1.1.0")
    -  lazy val recall: Double = precision
    +  lazy val recall: Double = accuracy
    --- End diff --
    
    Hm, I think we need to deprecate `recall` for the same reason. 
    You can leave the comment alone, because the logic it gives explains why it 
would be equal to precision and not accuracy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to