Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12781#discussion_r62161666
  
    --- Diff: 
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -45,7 +45,9 @@ statement
         | ALTER DATABASE identifier SET DBPROPERTIES tablePropertyList     
#setDatabaseProperties
         | DROP DATABASE (IF EXISTS)? identifier (RESTRICT | CASCADE)?      
#dropDatabase
         | createTableHeader ('(' colTypeList ')')? tableProvider
    -        (OPTIONS tablePropertyList)?                                   
#createTableUsing
    +        (OPTIONS tablePropertyList)?
    +        (PARTITIONED BY partitionColumnNames=identifierList)?
    +        bucketSpec?                                                    
#createTableUsing
         | createTableHeader tableProvider
    --- End diff --
    
    not related to this PR, but should we combine these 2 rules? They are all 
called `createTableUsing` but the second one is actually 
`createTableUsingAsSelect`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to