Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12896#discussion_r62163670
--- Diff: python/pyspark/ml/tests.py ---
@@ -1027,6 +1027,21 @@ def test_storage_levels(self):
self.assertEqual(als.getFinalStorageLevel(), "DISK_ONLY")
self.assertEqual(als._java_obj.getFinalStorageLevel(), "DISK_ONLY")
+ def test_unknown_strategy(self):
--- End diff --
@BryanCutler yeah, it would fail when `fit` is called - on the JVM side
actually as that is where the validation occurs. It's due to the wrapper as you
say, not much we can do on the Python side for now.
Since we test invalid params in the Scala suite, I don't think it's
necessary to test them again here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]