Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/12895#issuecomment-217177347
I think this is good, but while we're here can we make this a full audit of
tree params? @dominik-jastrzebski would you mind having a look at the
correctness of the other params `treeParams.scala`? For instance, the
`impurity` validator
[here](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala#L195)
should use `ParamValidators.inArray(...)` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
