Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11546#discussion_r62279170
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1108,11 +1118,14 @@ private[spark] class BlockManager(
def removeBlock(blockId: BlockId, tellMaster: Boolean = true): Unit = {
logDebug(s"Removing block $blockId")
val info = blockInfo.get(blockId).orNull
- if (info != null) {
+ if (info != null && !pendingToRemove.containsKey(blockId)) {
+ pendingToRemove.put(blockId, currentTaskAttemptId)
--- End diff --
Actually, on closer inspection I believe this is still not safe. You need
to use something like `pendingToRemove.putIfAbsent` to do this atomically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
