Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12943#discussion_r62286255
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
---
@@ -88,7 +88,7 @@ private[ml] trait MultilayerPerceptronParams extends
PredictorParams
* @group expertParam
*/
final val weights: Param[Vector] = new Param[Vector](this, "weights",
- " Sets the weights of the model ")
+ "Weights (either initial if before training or actual on model)")
--- End diff --
No I think `Model weights. Can be returned either after training or after
explicit setting` leaves a lot to be understood compared to explaining that it
can be the initial weights if before training or the actual weights after
training on the model. I'll update the Scaladoc on the setter to match.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
