Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12954#discussion_r62377447
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -1645,3 +1646,30 @@ object RewriteCorrelatedScalarSubquery extends 
Rule[LogicalPlan] {
           }
       }
     }
    +
    +/**
    + * Rewrite [[Filter]] plans that contain correlated [[ScalarSubquery]] 
expressions. When these
    + * correlated [[ScalarSubquery]] expressions are wrapped in a some 
Predicate expression, we rewrite
    + * them into [[PredicateSubquery]] expressions.
    + */
    +object RewriteScalarSubqueriesInFilter extends Rule[LogicalPlan] {
    --- End diff --
    
    This rule is not necessary for this fix, right?
    
    Also, we have a rule to turn outer join into semi join if possible, does 
that one not work in case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to