Github user sarutak commented on the pull request:
https://github.com/apache/spark/pull/11301#issuecomment-217718491
@kiszk I've left some comments.
Further more, I noticed a big problem of this change.
The call site to be embedded into generated source code includes
line-number.
If we call a same queries multiple time, generated codes are essentially
equal except for the line-numbers.
Because of the difference of the comments, those generated source codes are
both compiled even though they are essentially equal.
May be this problem can be resolved by #12979 .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
