Github user xwu0226 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12974#discussion_r62453423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DistinctAggregationRewriter.scala
---
@@ -123,15 +119,7 @@ case class DistinctAggregationRewriter(conf:
CatalystConf) extends Rule[LogicalP
.filter(_.isDistinct)
.groupBy(_.aggregateFunction.children.toSet)
- val shouldRewrite = if (conf.specializeSingleDistinctAggPlanning) {
--- End diff --
This flag is for the purpose of benchmarking the performance of single
distinct aggregation by `DistinctAggregationRewriter`. The default value is
false, which means `DistinctAggregationRewriter` will not be used for a single
distinct case. I see 2.0 has removed this flag, so i guess the decision has
been made. If it is still needed for 1.6, I can add it back, which will
involves more change in Optimizer to take the CatalystConf. Please let me
know. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
