Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12949#discussion_r62561309
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -239,8 +239,13 @@ case class DataSource(
}
}
- /** Create a resolved [[BaseRelation]] that can be used to read data
from this [[DataSource]] */
- def resolveRelation(): BaseRelation = {
+ /**
+ * Create a resolved [[BaseRelation]] that can be used to read data from
or write data into this
+ * [[DataSource]]
+ *
+ * @param checkPathExist A flag to indicate whether to check the
existence of path or not.
--- End diff --
It will be good to add why we need to this flag. Also, let's see how to
clean it up in future. It's kind of weird to have a flag like this at here.
I will update the doc and merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
