Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13023#discussion_r62643605
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -108,28 +107,32 @@ setMethod(
     #' @param maxit Integer giving the maximal number of IRLS iterations.
     #' @return a fitted generalized linear model
     #' @rdname glm
    +#' @name glm
     #' @export
     #' @examples
     #' \dontrun{
     #' sc <- sparkR.init()
     #' sqlContext <- sparkRSQL.init(sc)
     #' data(iris)
     #' df <- createDataFrame(sqlContext, iris)
    -#' model <- glm(Sepal_Length ~ Sepal_Width, df, family="gaussian")
    +#' model <- glm(Sepal_Length ~ Sepal_Width, df, family = "gaussian")
     #' summary(model)
     #' }
     setMethod("glm", signature(formula = "formula", family = "ANY", data = 
"SparkDataFrame"),
               function(formula, family = gaussian, data, epsilon = 1e-06, 
maxit = 25) {
                 spark.glm(data, formula, family, epsilon, maxit)
               })
    --- End diff --
    
    Because ```glm``` is R-compliant function, so I left the argument names 
consistent with native R.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to