Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/13035#discussion_r62767519
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -248,6 +249,18 @@ public long getPeakMemoryUsedBytes() {
}
/**
+ * @return the total amount of time spent sorting data (in-memory only).
+ */
+ public long getSortTimeNanos() {
+ long totalTime = totalSortTimeNanos;
+ UnsafeInMemorySorter sorter = inMemSorter;
+ if (sorter != null) {
--- End diff --
There is very small chance to double-count it when this is called between
`totalSortTimeNanos += inMemSorter.getSortTimeNanos()` and `getSortTimeNanos()`
Since we have only one UnsafeInMemorySorter, we should return either
`inMemSorter.getSortTimeNanos()` or `totalSortTimeNanos `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
