Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13022#discussion_r62774973
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -531,18 +531,29 @@ private[hive] class
HiveMetastoreCatalog(sparkSession: SparkSession) extends Log
/**
* An override of the standard HDFS listing based catalog, that overrides
the partition spec with
* the information from the metastore.
+ * @param tableBasePath The default base path of the Hive metastore table
+ * @param partitionSpec The partition specifications from Hive metastore
*/
private[hive] class MetaStoreFileCatalog(
--- End diff --
I am inclined to rename this class to
`MetastorePartitionedTableFileCatalog` as this is only used for partitioned
tables, and therefore does not need to worry about what files to return when
the tables is not partitioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
