Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1764#discussion_r15743214
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
    @@ -266,7 +266,8 @@ package object dsl {
     
       object plans {  // scalastyle:ignore
         implicit class DslLogicalPlan(val logicalPlan: LogicalPlan) extends 
LogicalPlanFunctions {
    -      def writeToFile(path: String) = WriteToFile(path, logicalPlan)
    +    // Writing to files doesn't make sense without Hadoop in scope (unless 
we assume local fs)
    +//      def writeToFile(path: String) = WriteToFile(path, classOf[??], 
logicalPlan)
    --- End diff --
    
    Not sure what to do with this, it doesn't seem to make a lot of sense in 
the catalyst package unless catalyst wants to depend on Hadoop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to