Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13042#discussion_r62799243
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java
---
@@ -109,6 +128,27 @@ public static void deleteRecursively(File file) throws
IOException {
}
}
+ private static void deleteRecursivelyForUnix(File file) throws
IOException {
+ Process process = null;
+ final ProcessBuilder builder = new ProcessBuilder("rm", "-rf",
file.getAbsolutePath());
+
+ try {
+ process = builder.start();
+ process.waitFor();
+ if (process.exitValue() == 0 && !file.exists()) {
+ return;
+ }
+
+ throw new IOException("Failed to delete: " + file.getAbsolutePath());
--- End diff --
This is caught by the containing block. Maybe store the status and take the
check above out of the try block then for clarity
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
