Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12882#discussion_r62821482
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/MulticlassMetricsSuite.scala
---
@@ -72,6 +72,7 @@ class MulticlassMetricsSuite extends SparkFunSuite with
MLlibTestSparkContext {
assert(math.abs(metrics.recall -
--- End diff --
Also it would be tidier to change the test to first assert about accuracy,
and then assert that every other metric is close to accuracy, rather than to
recall. Actually, we should assert exact equality in all of those comparisons
to precision, recall etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
