Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12916#issuecomment-218416369
@bomeng this is looking nice. The last worry I have is about the
javax.servlet dependency. I remember we had significant problems with servlet
containers bringing in their own copy under their own artifact name, and
conflicting with the main `javax.servlet` artifact. I think we ended up
excluding everything except Jetty's copy. That seems to be changed in this PR,
which could be fine. But if you would try `mvn dependency:tree` and grep for
any "javax.+servlet" artifacts, and see if anything whose version looks like
it's less than 3.1.0 is still included. (Likewise maybe we can remove some old
excludes of stuff like this, but I'm not as worried.)
If there are no other servlet APIs coming in, I'm down with this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
